vemikhaylov commented on code in PR #29608:
URL: https://github.com/apache/airflow/pull/29608#discussion_r1141076082
##########
airflow/cli/commands/task_command.py:
##########
@@ -596,6 +597,10 @@ def task_test(args, dag=None):
task, args.map_index,
exec_date_or_run_id=args.execution_date_or_run_id, create_if_necessary="db"
)
+ xcoms = args.xcoms or []
+ _validate_injected_xcoms(xcoms, task)
Review Comment:
> I don’t see why you need to raise that exception
Let me clarify if you are questioning why we should raise an exception at
all (like not go with returning a bool flag or something) or you're not sure if
we need the `AirflowException` class here? If it's the latter, what is the
intended scenario for that? I just noticed that it had been used for the args
validation in the module.
But generally absolutely aligned! Actually I also mentioned that it may've
been intercepted and enriched, definitely not a blocker, just a consideration.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
