vemikhaylov commented on code in PR #30180: URL: https://github.com/apache/airflow/pull/30180#discussion_r1141189098
########## airflow/models/xcom.py: ########## @@ -57,14 +57,13 @@ from airflow.utils.log.logging_mixin import LoggingMixin from airflow.utils.session import NEW_SESSION, provide_session from airflow.utils.sqlalchemy import UtcDateTime +from airflow.utils.xcom import ( + MAX_XCOM_SIZE, # noqa: F401 (#30180 - leaving it for providers backward compatibility) + XCOM_RETURN_KEY, +) Review Comment: > The test is right Yeah, sure, I didn't have any doubts around that :) > For exampele import the new constants in the old place and mark it with comments to remove it when min-airflow-version is 2.6. Makes sense to me, I think this is exactly what I came up with, I'll extend the comment with the minimal airflow version according to your proposal then, thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
