coufon commented on a change in pull request #5594: [AIRFLOW-4924] Loading DAGs asynchronously in Airflow webserver URL: https://github.com/apache/airflow/pull/5594#discussion_r304672621
########## File path: airflow/www/async_dag_loaders.py ########## @@ -0,0 +1,200 @@ +# -*- coding: utf-8 -*- +# +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. + +"""Asynchronous DAG loader that collects DAGs in background. + +broad-except is used in many places to capture all exceptions, to +make sure when loading one DAG fails, it does not affect other DAGs. +""" + +import copy +import importlib +import logging +import pickle +import signal +import sys +import threading +import time +from collections import defaultdict +from multiprocessing import Event +from multiprocessing import Process +from multiprocessing import Queue + +from airflow import configuration +from airflow.dag.stringified_dags import stringify +from airflow.exceptions import AirflowConfigException +from airflow.models import DagBag + + +def _read_config(field, default): + try: + return configuration.getint('webserver', field) + except AirflowConfigException: + return default + + +# Interval to send dagbag back to main process. +DAGBAG_SYNC_INTERVAL = _read_config('dagbag_sync_interval', 10) Review comment: Fixed in all places. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
