ferruzzi commented on code in PR #30162:
URL: https://github.com/apache/airflow/pull/30162#discussion_r1142513135
##########
airflow/providers/amazon/aws/hooks/glue.py:
##########
@@ -162,8 +165,11 @@ def initialize_job(
run_kwargs = run_kwargs or {}
try:
- job_name = self.create_or_update_glue_job()
- return self.get_conn().start_job_run(JobName=job_name,
Arguments=script_arguments, **run_kwargs)
+ if self.update_config:
+ self.create_or_update_glue_job()
+ return self.get_conn().start_job_run(
Review Comment:
Small nitpick, if you'd be so kind. We are trying to encourage using the
`self.conn` cached property over the `self.get_conn()` getter method. If you
are so inclined, could you make that change here and in the relevant test
below?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
