phanikumv commented on code in PR #29266:
URL: https://github.com/apache/airflow/pull/29266#discussion_r1143097143
##########
tests/providers/google/cloud/hooks/test_kubernetes_engine.py:
##########
@@ -20,12 +20,13 @@
import sys
from asyncio import Future
+import kubernetes.client
import pytest
from google.cloud.container_v1 import ClusterManagerAsyncClient
from google.cloud.container_v1.types import Cluster
from airflow.exceptions import AirflowException
-from airflow.providers.google.cloud.hooks.kubernetes_engine import
AsyncGKEHook, GKEHook
+from airflow.providers.google.cloud.hooks.kubernetes_engine import
AsyncGKEHook, AsyncGKEPodHook, GKEHook
Review Comment:
```suggestion
from airflow.providers.google.cloud.hooks.kubernetes_engine import
GKEAsyncHook, GKEPodAsyncHook, GKEHook
```
naming should be inline with other async hooks across the repo
##########
docs/apache-airflow-providers-google/operators/cloud/kubernetes_engine.rst:
##########
@@ -148,6 +148,14 @@ And then use it in other operators:
:start-after: [START howto_operator_gke_xcom_result]
:end-before: [END howto_operator_gke_xcom_result]
+You can use deferrable mode for this action in order to run the operator
asynchronously:
Review Comment:
```suggestion
You can set the parameter deferrable = True in order to run the operator
asynchronously:
```
##########
tests/providers/google/cloud/hooks/test_kubernetes_engine.py:
##########
@@ -291,6 +296,72 @@ def test_wait_for_response_running(self, time_mock,
operation_mock):
assert operation_mock.call_count == 2
+class TestAsyncGKEPodHook:
Review Comment:
```suggestion
class TestGKEPodAsyncHook:
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
