Lee-W opened a new pull request, #30235:
URL: https://github.com/apache/airflow/pull/30235

   <!--
   Thank you for contributing! Please make sure that your code changes
   are covered with tests. And in case of new features or big changes
   remember to adjust the documentation.
   
   Feel free to ping committers for the review!
   
   In case of an existing issue, reference it using one of the following:
   
   closes: #ISSUE
   related: #ISSUE
   
   How to write a good git commit message:
   http://chris.beams.io/posts/git-commit/
   -->
   
   ### Why making this change?
   apache-airflow-providers-google treats the deferred execution of its 
operators and sensors differently, which might cause confusion. For example, 
[BigQueryCheckOperator](https://github.com/apache/airflow/blob/main/airflow/providers/google/cloud/operators/bigquery.py#L200)
 uses the 
[deferrable](https://github.com/apache/airflow/blob/main/airflow/providers/google/cloud/operators/bigquery.py#L200)
 parameter to toggle deferred execution while we need to use another sensor for 
[BigQueryTableExistenceSensor](https://github.com/apache/airflow/blob/main/airflow/providers/google/cloud/sensors/bigquery.py#L37)
 (i.e., 
[BigQueryTableExistenceAsyncSensor](https://github.com/apache/airflow/blob/main/airflow/providers/google/cloud/sensors/bigquery.py#L182))
 to achieve the same thing.
   
   ### What's changed?
   In this pull request, I move the deferred logic from 
[BigQueryTableExistenceAsyncSensor](https://github.com/apache/airflow/blob/main/airflow/providers/google/cloud/sensors/bigquery.py#L219)
 to 
[BigQueryTablePartitionExistenceSensor](https://github.com/apache/airflow/blob/main/airflow/providers/google/cloud/sensors/bigquery.py#L106)
 so that we can keep the consistency and reduce maintenance effort. Instead of 
removing 
[BigQueryTableExistenceAsyncSensor](https://github.com/apache/airflow/blob/main/airflow/providers/google/cloud/sensors/bigquery.py#L182),
 I add a deprecation warning in case users're using it.
   
   ---
   **^ Add meaningful description above**
   
   Read the **[Pull Request 
Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)**
 for more information.
   In case of fundamental code changes, an Airflow Improvement Proposal 
([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals))
 is needed.
   In case of a new dependency, check compliance with the [ASF 3rd Party 
License Policy](https://www.apache.org/legal/resolved.html#category-x).
   In case of backwards incompatible changes please leave a note in a 
newsfragment file, named `{pr_number}.significant.rst` or 
`{issue_number}.significant.rst`, in 
[newsfragments](https://github.com/apache/airflow/tree/main/newsfragments).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to