potiuk commented on PR #29055: URL: https://github.com/apache/airflow/pull/29055#issuecomment-1479426300
I looked at the "Wait for prod images" change and I think this change triggers a very subtle error @o-nikolas https://github.com/apache/airflow/actions/runs/4484706055/jobs/7886151068?pr=29055 I believe the root cause is that the changes implemented in this PR move the intiialization of executors to earlier moment (and likely to one where it is not needed). The failure above, I think shows that serializers of ours are initialized before the CLI command `airflow providers list` gets executed. The command has `@suppress_logs_and_warnings` decorator - so that `--output` from the command is "proper" (For example JSON). Seems that with this change the serde serialization is executed before the decorator comes into action and the log is not suppressed - thus making the output anything-but-json. Might be an indication of a side effect where it will slow down all CLI s and produce this log output on the stdout for all the commands (including all other commands with output. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
