huymq1710 commented on code in PR #30116:
URL: https://github.com/apache/airflow/pull/30116#discussion_r1142353099


##########
airflow/models/dagbag.py:
##########
@@ -702,7 +702,7 @@ def needs_perms(dag_id: str) -> bool:
                     return True
             return False
 
-        if dag.access_control or needs_perms(root_dag_id):
+        if dag.access_control or not needs_perms(root_dag_id):

Review Comment:
   Hi @jedcunningham,
   I just removed `if dag.access_control or needs_perms(root_dag_id):` and `if 
access_control:`. This is effectively reverting 
https://github.com/apache/airflow/pull/15464. But 
https://github.com/apache/airflow/issues/25149 will be resolved, I think.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to