Remmertmuller commented on issue #30236: URL: https://github.com/apache/airflow/issues/30236#issuecomment-1481143600
Okay! Yes I am willing to contribute. There will be three places where autocommit can be configured, so I suggest the following precedence: 1. value given to run() => if run is called with autocommit explicitly set to True or False, then that is what it should do. 2. value from the session parameter from instantiating the hook. 3. value from the session parameter from the connection. If autocommit is not set in any of these three places, default behaviour remains False. When scanning the code I could not find where any of the session parameters are set. Session parameters are given to connect() on the SnowflakeConnection, but this function does not do anything with session parameters. However, this change will still be needed because we need to make sure that the default value from run() does not overwrite autocommit from the session parameters anyway. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
