erdos2n commented on issue #30264: URL: https://github.com/apache/airflow/issues/30264#issuecomment-1482733842
@eladkal Maybe they should not be set to fail, but they should also not be set to skipped. The task was not skipped, technically speaking. An issue that has come up is that a user wants an alert for a specific task failure, so they don't want to set the `on_failure_callback` on the dag level. That specific task gets marked skipped on a `dagrun_timeout` and the `on_failure_callback` isn't triggered. I believe it's worth discussing either marking these tasks that are stopped mid-run as FAILED or introducing a new state into the task instance. I'm curious if `SHUTDOWN` makes more sense in this instance. It seems to fit what is occurring more than skipped. ``` SHUTDOWN # External request to shut down (e.g. marked failed when running) ``` https://github.com/apache/airflow/blob/main/airflow/utils/state.py#L42 Thoughts? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
