ephraimbuddy commented on code in PR #30271:
URL: https://github.com/apache/airflow/pull/30271#discussion_r1147738748


##########
airflow/models/dag.py:
##########
@@ -2207,6 +2207,9 @@ def partial_subset(
                 also_include.extend(t.get_flat_relatives(upstream=False))
             if include_upstream:
                 also_include.extend(t.get_flat_relatives(upstream=True))
+            else:
+                upstream_setup_tasks = t.get_flat_relatives(upstream=True, 
setup_only=True)
+                also_include.extend(upstream_setup_tasks)

Review Comment:
   I think I didn't understand the code well. Your explanation makes sense. I 
was thinking that if `include_upstream` is selected by the user then the else 
part will not run but from your explanation it's handled in get_flat_relatives



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to