elongl commented on code in PR #30214:
URL: https://github.com/apache/airflow/pull/30214#discussion_r1148010845
##########
tests/charts/test_airflow_common.py:
##########
@@ -234,21 +234,25 @@ def
test_global_affinity_tolerations_topology_spread_constraints_and_node_select
assert "foo" ==
jmespath.search("topologySpreadConstraints[0].topologyKey", podSpec)
@pytest.mark.parametrize(
- "use_default_image,expected_image",
+ "use_default_image,expected_image,tag,digest",
[
- (True, "apache/airflow:2.1.0"),
- (False, "apache/airflow:user-image"),
+ (True, "apache/airflow:2.1.0", None, None),
+ (False, "apache/airflow:user-tag", "user-tag", None),
+ (False, "apache/airflow@user-digest", None, "user-digest"),
+ (False, "apache/airflow@user-digest", "user-tag", "user-digest"),
Review Comment:
Sorry, care to clarify what do you mean by that?
I'm a bit confused as `defaultAirflowDigest` is a constant value.
What is the test-case that needs to be added?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
