potiuk commented on PR #30255: URL: https://github.com/apache/airflow/pull/30255#issuecomment-1483797618
All right - I think that one has a chance to pass all the tests, I fixed all the remaining issues and TODOs that I wanted to fix in this scope. Remaining things to make it AIP-44-ready (will be in follow-up PRs): * rename the job runner packages (separte small PR) * split `run` method of BaseJob into "start", "execute", "stop" - so that `start` and `stop` can be run over internal-api * make `heartbeat` run over internal API (I already extracted it to make it easy * make sure `LocalTaskJob` heartbeat_callback is handled properlly (it will have to run in the context of internal_api and pass modification of the local-task-job back to the caller of heartbeat I **think** once those changes will be complete, the LocalTask mechanism will be AIP-44 ready and we will have a nice db/non-db separation. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
