RachitSharma2001 commented on PR #29406: URL: https://github.com/apache/airflow/pull/29406#issuecomment-1483893796
Hi everyone, I have added the following changes: 1. Changed DAG 'fail_fast' to 'fail_stop' ([here](https://github.com/RachitSharma2001/airflow/blob/fail-fast-pr/airflow/models/dag.py#L426)) 2. dag.add_task throws an exception if the task has a trigger rule that is not 'all_success' ([here](https://github.com/RachitSharma2001/airflow/blob/fail-fast-pr/airflow/models/dag.py#L2365)) a. I have also added a test for this [here](https://github.com/apache/airflow/pull/29406/files#diff-020d9b727c01b132cc07f0e2f35e93508e26f700bae5350018269a0ce487b4b7). 3. BaseOperator throws an exception if the task has a trigger rule that is not 'all_success' and the given dag is a 'fail_stop" dag. ([here](https://github.com/apache/airflow/pull/29406/files#diff-848f325ace55b3504e8052fecdb53c0f295c891b67a6d90e9341cbe79cc545fb)) a. I have added a test for this [here](https://github.com/apache/airflow/pull/29406/files#diff-8c9a41e08abb1a5298aad12a2bd686633b706112a8a15e371e0ec9c4aedc77e0) 4. Documented what the fail stop parameter does, with a warning about trigger rules. ([here](https://github.com/RachitSharma2001/airflow/blob/fail-fast-pr/airflow/models/dag.py#L361)) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
