hussein-awala commented on code in PR #30310:
URL: https://github.com/apache/airflow/pull/30310#discussion_r1148671668
##########
airflow/providers/docker/hooks/docker.py:
##########
@@ -87,6 +87,7 @@ def construct_tls_config(
ca_cert: str | None = None,
client_cert: str | None = None,
client_key: str | None = None,
+ verify: bool | None = None,
Review Comment:
Even though the `TLSConfig` init accepts `None`, and since it considers it
`False`, it's better to only accept bool in our class and set default to
`False`:
```suggestion
verify: bool = False,
```
##########
airflow/providers/docker/operators/docker.py:
##########
@@ -186,6 +187,7 @@ def __init__(
tls_ca_cert: str | None = None,
tls_client_cert: str | None = None,
tls_client_key: str | None = None,
+ tls_verify: bool | None = None,
Review Comment:
```suggestion
tls_verify: bool = False,
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
