sudeepgupta90 commented on code in PR #30303:
URL: https://github.com/apache/airflow/pull/30303#discussion_r1148790793
##########
chart/templates/configmaps/extra-configmaps.yaml:
##########
@@ -39,6 +39,9 @@ metadata:
"helm.sh/hook": "pre-install,pre-upgrade"
"helm.sh/hook-delete-policy": "before-hook-creation"
"helm.sh/hook-weight": "0"
+ {{- if $configMapContent.annotations }}
+ {{- toYaml $configMapContent.annotations | nindent 4 }}
+ {{- end }}
Review Comment:
I looked this up. My changes were aligned with the recent changes to these
specific files. Code readability took precedence as I didnt want to have 2
different code patterns in the same file when it has no affect on intended
functionality. Thanks for suggesting, and I will be sure to keep this in mind
in my future PRs as well
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
