huymq1710 commented on code in PR #30340:
URL: https://github.com/apache/airflow/pull/30340#discussion_r1150073920
##########
airflow/www/security.py:
##########
@@ -641,8 +641,25 @@ def sync_perm_for_dag(self, dag_id, access_control=None):
for dag_action_name in self.DAG_ACTIONS:
self.create_permission(dag_action_name, dag_resource_name)
+ def _revoke_all_stale_permissions(resource: Resource):
+ existing_dag_perms = self.get_resource_permissions(resource)
+ for perm in existing_dag_perms:
+ non_admin_roles = [role for role in perm.role if role.name !=
"Admin"]
+ for role in non_admin_roles:
+ self.log.info(
+ "Revoking '%s' on DAG '%s' for role '%s'",
+ perm.action,
+ dag_resource_name,
+ role.name,
+ )
+ self.remove_permission_from_role(role, perm)
+
if access_control:
self._sync_dag_view_permissions(dag_resource_name, access_control)
+ else:
+ resource = self.get_resource(dag_resource_name)
+ if resource:
+ _revoke_all_stale_permissions(resource)
Review Comment:
If a DAG’s `access_control` is empty, it check whether there’s existing
permission configurations and reset those
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
