eladkal commented on code in PR #30326:
URL: https://github.com/apache/airflow/pull/30326#discussion_r1150633859
##########
airflow/providers/google/marketing_platform/operators/display_video.py:
##########
@@ -108,6 +114,79 @@ def execute(self, context: Context) -> dict:
return response
+class GoogleDisplayVideo360CreateQueryOperator(BaseOperator):
+ """
+ Creates a query.
+
+ .. seealso::
+ For more information on how to use this operator, take a look at the
guide:
+ :ref:`howto/operator:GoogleDisplayVideo360CreateQueryOperator`
+
+ .. seealso::
+ Check also the official API docs:
+ `https://developers.google.com/bid-manager/v1/queries/createquery`
+
+ :param body: Report object passed to the request's body as described here:
+ https://developers.google.com/bid-manager/v1/queries#resource
Review Comment:
same q
##########
airflow/providers/google/marketing_platform/operators/display_video.py:
##########
@@ -108,6 +114,79 @@ def execute(self, context: Context) -> dict:
return response
+class GoogleDisplayVideo360CreateQueryOperator(BaseOperator):
+ """
+ Creates a query.
+
+ .. seealso::
+ For more information on how to use this operator, take a look at the
guide:
+ :ref:`howto/operator:GoogleDisplayVideo360CreateQueryOperator`
+
+ .. seealso::
+ Check also the official API docs:
+ `https://developers.google.com/bid-manager/v1/queries/createquery`
Review Comment:
is v1 the right link?
##########
airflow/providers/google/CHANGELOG.rst:
##########
@@ -23,6 +23,15 @@
Changelog
---------
+9.0.0
+.....
+
+Breaking changes
+~~~~~~~~~~~~~~~~
+
+* ``Migrate DV360 operators to use API v2 (#30326)``
Review Comment:
Can we say a bit more?
explain what is changed? maybe link to the google relevant migration docs?
the goal is to prevent questions of users "what do we need to do"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
