uranusjr commented on code in PR #30330:
URL: https://github.com/apache/airflow/pull/30330#discussion_r1151648866
##########
airflow/models/dagrun.py:
##########
@@ -164,9 +164,7 @@ class DagRun(Base, LoggingMixin):
),
)
- task_instances = relationship(
- TI, back_populates="dag_run", cascade="save-update, merge, delete,
delete-orphan"
- )
+ task_instances = relationship(TI, back_populates="dag_run",
cascade="save-update, merge")
Review Comment:
I would prefer we keep these since we still need to delete those associated
task instances when a DAG run is deleted by other means.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
