Taragolis commented on code in PR #30032:
URL: https://github.com/apache/airflow/pull/30032#discussion_r1152485974
##########
airflow/providers/amazon/aws/hooks/base_aws.py:
##########
@@ -72,7 +74,7 @@
class BaseSessionFactory(LoggingMixin):
"""
- Base AWS Session Factory class to handle boto3 session creation.
+ Base AWS Session Factory class to handle synchronous and async boto
session creation.
Review Comment:
This is not technically correct, not all `async` implementation is
`asyncio`. Asyncio stand for asynchronous IO (KO)
And the problem still the same: mixup blocking io and asyncio
implementation, see:
https://github.com/apache/airflow/pull/30032#discussion_r1136239727, as result
> This PR only uses blocking io implementation, that mean event loop of
triggerer would be blocked.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
