syedahsn commented on code in PR #30032:
URL: https://github.com/apache/airflow/pull/30032#discussion_r1153657308
##########
airflow/providers/amazon/aws/hooks/base_aws.py:
##########
@@ -72,7 +74,7 @@
class BaseSessionFactory(LoggingMixin):
"""
- Base AWS Session Factory class to handle boto3 session creation.
+ Base AWS Session Factory class to handle synchronous and async boto
session creation.
Review Comment:
I can work on the wording here. The idea is that the hook will start
supporting async operations. It doesn't necessarily need to support all the
features that the synchronous session supports, and we can incrementally add in
additional things as required.
>And the problem still the same: mixup blocking io and asyncio
implementation,
Can you provide some more information about this? I'm not sure what you
mean. There is a [watchdog
mechanism](https://github.com/apache/airflow/blob/main/airflow/jobs/triggerer_job.py#L547)
in Airflow which prints out a warning if the async thread is blocked for too
long.
For this PR, the trigger, which contains all the async code, is only
creating the async client, which is a necessary task, and making the network
call which is async. The client creation only happens once per execution of a
Trigger.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
