mik-laj commented on issue #5539: [AIRFLOW-4811] Implement GCP DLP' Hook and Operators URL: https://github.com/apache/airflow/pull/5539#issuecomment-513106558 Hi. I looked at it quickly and it seems to me that there are no tests for the project_id parameter in the hook. I will look at it in a few hours. If you wait, I will probably write the missing tests for you. My team enters the next phase with integration for GCP. We want to improve the stability of existing operators (including fixing bug), but also to adjust existing operators to the guideline. https://docs.google.com/document/d/1_rTdJSLCt0eyrAylmmgYc3yZr-_h51fVlnvMmWqhCkY/edit?ts=5bb72dfd#heading=h.3sxddzjr5f6q To do this, the review will be much more detailed, but unfortunately it takes some time.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
