eladkal commented on code in PR #30270:
URL: https://github.com/apache/airflow/pull/30270#discussion_r1154284290
##########
airflow/ti_deps/deps/trigger_rule_dep.py:
##########
@@ -213,13 +230,18 @@ def _iter_upstream_conditions() ->
Iterator[ColumnOperators]:
# "simple" tasks (no task or task group mapping involved).
if not any(needs_expansion(t) for t in upstream_tasks.values()):
upstream = len(upstream_tasks)
+ upstream_setup = len(
+ [x for x in upstream_tasks.values() if not isinstance(x,
MappedOperator) and x._is_setup]
+ )
else:
upstream = (
session.query(func.count())
.filter(TaskInstance.dag_id == ti.dag_id, TaskInstance.run_id
== ti.run_id)
.filter(or_(*_iter_upstream_conditions()))
.scalar()
)
+ # todo: add support for mapped setup?
Review Comment:
Can you elaborate on this one?
What is the issue with mapped tasks?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
