mikaeld commented on code in PR #24588:
URL: https://github.com/apache/airflow/pull/24588#discussion_r1154515537
##########
chart/templates/statsd/statsd-deployment.yaml:
##########
@@ -87,6 +88,9 @@ spec:
- name: statsd
image: {{ template "statsd_image" . }}
imagePullPolicy: {{ .Values.images.statsd.pullPolicy }}
+ securityContext: {{ $containerSecurityContext | nindent 12 }}
+ args:
+ - "--statsd.mapping-config=/etc/statsd-exporter/mappings.yml"
{{- if .Values.statsd.args }}
args: {{ tpl (toYaml .Values.statsd.args) . | nindent 12 }}
{{- end }}
Review Comment:
`args` is duplicated
```suggestion
{{- if .Values.statsd.args }}
args: {{ tpl (toYaml .Values.statsd.args) . | nindent 12 }}
{{- else}}
args:
- "--statsd.mapping-config=/etc/statsd-exporter/mappings.yml"
{{- end }}
```
##########
chart/templates/webserver/webserver-deployment.yaml:
##########
@@ -171,6 +175,7 @@ spec:
{{- end }}
resources:
{{ toYaml .Values.webserver.resources | indent 12 }}
+ securityContext: {{ or .Values.webserver.securityContexts.container
.Values.securityContexts.container }}
Review Comment:
In my local testing, this adds a duplicate `securityContext` key
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
