o-nikolas commented on code in PR #30404:
URL: https://github.com/apache/airflow/pull/30404#discussion_r1154865278


##########
airflow/api_connexion/endpoints/dag_run_endpoint.py:
##########
@@ -18,7 +18,7 @@
 
 from http import HTTPStatus
 
-import pendulum

Review Comment:
   The `pendulum` module must be loaded in either case here. I don't think you 
will see a performance gain from a change like this.
   
   I ran a very quick couple of commands to test this:
   ![Screenshot from 2023-03-31 
13-20-06](https://user-images.githubusercontent.com/65743084/229222012-9c22672a-d438-4b43-a544-0f38d381604f.png)
   
   You can see that they're the same (even the `from` case being slower, but 
this is normal variance of course).
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to