slmg opened a new issue, #30420:
URL: https://github.com/apache/airflow/issues/30420

   ### Official Helm Chart version
   
   1.8.0 (latest released)
   
   ### Apache Airflow version
   
   2.5.1
   
   ### Kubernetes Version
   
   1.21.14
   
   ### Helm Chart configuration
   
   ```yaml
   # values.yaml
   
   executor: "KubernetesExecutor"
   ```
   
   ### Docker Image customizations
   
   None.
   
   ### What happened
   
   The [redis 
secrets](https://github.com/apache/airflow/blob/2.5.1/chart/templates/secrets/redis-secrets.yaml)
 got created
   
   ### What you think should happen instead
   
   Given all the resources defined in 
[./chart/templates/redis](https://github.com/apache/airflow/tree/2.5.1/chart/templates/redis)
 contain the below condition, it does not seem right to me to get Redis secrets 
created in the context of the `KubernetesExecutor`. 
   
   ```go
   {{- if and .Values.redis.enabled (or (eq .Values.executor "CeleryExecutor") 
(eq .Values.executor "CeleryKubernetesExecutor")) }}
   ```
   
   Redis secrets might have been missed when this condition was added, because 
they are located in a different folder?
   
   ### How to reproduce
   
   Render helm templates
   ```sh
   helm template test apache-airflow/airflow --version --values values.yaml > 
rendered.yaml
   ```
   
   ### Anything else
   
   _No response_
   
   ### Are you willing to submit PR?
   
   - [X] Yes I am willing to submit a PR!
   
   ### Code of Conduct
   
   - [X] I agree to follow this project's [Code of 
Conduct](https://github.com/apache/airflow/blob/main/CODE_OF_CONDUCT.md)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to