mobuchowski commented on PR #29940: URL: https://github.com/apache/airflow/pull/29940#issuecomment-1494603822
@ashb >Can you explain to me what we are doing with all the git commands in ol/utils/utils.py? Where's that used and where does it end up? It ends up as `SourceCodeLocationJobFacet` https://openlineage.io/docs/spec/facets/job-facets/source-code-location >(I'm a little bit worried that some of the utils code "feels" like a lift-and-shift from the external repo without tying it in to Airflow's way of doing things. This isn't actionable feedback, mostly a comment at this point) Yeah - it's basically that. We wanted to keep Airflow specific changes - like adding Airflow config support - for later PRs, but given how long this is in review it was a bad idea. Maybe we should treat this instead as a rewrite from the beginning. There was also way more old cruft than I've thought... that's definitely on me. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
