potiuk commented on code in PR #30428:
URL: https://github.com/apache/airflow/pull/30428#discussion_r1157171936


##########
airflow/providers/amazon/aws/transfers/sftp_to_s3.py:
##########


Review Comment:
   Probably you do some mistake when rebasing. But what it is, hard to say. You 
can follow the "--rebase" pattern - it should not add files. You can use the 
GitHub UI to rebase (eaasier) or command line (more powerful and more arcane 
for those who are not used to git cli): see "How to Rebase" section 
https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#id14 
   
   I recommend to learn and master the CLI version, once you get used to doing 
it and do it often, it gets into a habit.  Also things like `liquidprompt` or 
oh-my-zsh and friends help a lot with seeing the status of your git repo in the 
command prompt are immensely helpful to see if you are doing it right. Usually 
rebase should result with only your commits that should be pushed on top of the 
current master. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to