josh-fell commented on code in PR #30406:
URL: https://github.com/apache/airflow/pull/30406#discussion_r1157605528
##########
tests/operators/test_trigger_dagrun.py:
##########
@@ -458,4 +480,15 @@ def
test_trigger_dagrun_with_wait_for_completion_true_defer_true_failure_2(self)
assert len(dagruns) == 1
with pytest.raises(AirflowException):
Review Comment:
Same comment here too.
##########
tests/operators/test_trigger_dagrun.py:
##########
@@ -434,7 +445,18 @@ def
test_trigger_dagrun_with_wait_for_completion_true_defer_true_failure(self):
assert len(dagruns) == 1
with pytest.raises(AirflowException):
Review Comment:
Since there are more than one AirflowException that can be thrown, it might
be a good idea to specify add a `match` here to make sure the proper
AirflowException is seen. WDYT?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
