mik-laj commented on a change in pull request #5612: [AIRFLOW-4583] Fixes type
error in GKEPodOperator
URL: https://github.com/apache/airflow/pull/5612#discussion_r305337792
##########
File path: airflow/contrib/operators/gcp_container_operator.py
##########
@@ -307,7 +307,7 @@ def _set_env_from_extras(self, extras):
else:
# Write service account JSON to secure file for gcloud to reference
service_key = tempfile.NamedTemporaryFile(delete=False)
- service_key.write(keyfile_json_str)
+ service_key.write(keyfile_json_str.encode('utf-8'))
Review comment:
in the base GCP hook class, I see a similar code -decorator It can not be
unified?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
