uranusjr commented on code in PR #30255:
URL: https://github.com/apache/airflow/pull/30255#discussion_r1159369070
##########
airflow/dag_processing/manager.py:
##########
@@ -576,8 +585,8 @@ def _run_parsing_loop(self):
while True:
loop_start_time = time.monotonic()
ready = multiprocessing.connection.wait(self.waitables.keys(),
timeout=poll_time)
- if self._job:
- self._job.heartbeat()
+ if hasattr(self._job_runner, "job") and self._job_runner.job is
not None:
Review Comment:
```suggestion
if getattr(self._job_runner, "job", None) is not None:
```
What’s the difference between `self._job_runner` not having the `job`
attribute, and the attribute being None though? It seems to me the attribute
can always be there and default to None.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
