uranusjr commented on code in PR #30255:
URL: https://github.com/apache/airflow/pull/30255#discussion_r1159370685
##########
airflow/dag_processing/manager.py:
##########
@@ -576,8 +585,8 @@ def _run_parsing_loop(self):
while True:
loop_start_time = time.monotonic()
ready = multiprocessing.connection.wait(self.waitables.keys(),
timeout=poll_time)
- if self._job:
- self._job.heartbeat()
+ if hasattr(self._job_runner, "job") and self._job_runner.job is
not None:
Review Comment:
Ah that may make `self.job` awkward in runner classes. I think that can be
improved with Generic but that could be an overkill. A comment here to briefly
describe what the lack of the attribute indicates should be good enough.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
