potiuk commented on PR #30495:
URL: https://github.com/apache/airflow/pull/30495#issuecomment-1498603126
I like the approach. Few things:
1) I think we will need some more detailed benchmarks
2) I think there is a flaw in just reading lines from python code, there are
- theorethically at lest - cases where imports are broken across multiple
lines. Reading lines from python sounds a bit hack-ish (AST parsing would be a
bit slower but much better).
But finally and more importantly:
3) Should not it be better to import all airlfow packages upfront? That
sounds like a much more robust solution, you only do it once at the start of
DAG file processor and you can even stop parsing DAG files at this point.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
