potiuk commented on code in PR #28848:
URL: https://github.com/apache/airflow/pull/28848#discussion_r1160452907


##########
kubernetes_tests/test_kubernetes_pod_operator.py:
##########
@@ -140,6 +146,7 @@ def _get_labels_selector(self) -> str | None:
             return None
         return ",".join([f"{key}={value}" for key, value in 
enumerate(self.labels)])
 
+    @pytest.mark.usefixtures("mock_get_connection")

Review Comment:
   Usefixtures makes little sense when put as method decorator (more typing, 
less explicit, only saves "unused parameter" in IDE. But it makes whole lot of 
sense when put on a class - can we please remove it it from the methods and put 
it once on TestKubernetesPodOperatorSystem instead?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to