potiuk commented on code in PR #30521:
URL: https://github.com/apache/airflow/pull/30521#discussion_r1160609352
##########
tests/conftest.py:
##########
@@ -38,6 +38,8 @@
os.environ["AIRFLOW__CORE__UNIT_TEST_MODE"] = "True"
os.environ["AWS_DEFAULT_REGION"] = os.environ.get("AWS_DEFAULT_REGION") or
"us-east-1"
os.environ["CREDENTIALS_DIR"] = os.environ.get("CREDENTIALS_DIR") or
"/files/airflow-breeze-config/keys"
+os.environ["AIRFLOW_ENABLE_AIP_44"] = os.environ.get("AIRFLOW_ENABLE_AIP_44")
or "true"
Review Comment:
This is the default if not set when our tests are run. This way the user wil
not have to set the variables in their tests when they run in from the IDE (cc:
@ephraimbuddy @jedcunningham @eladkal @pierrejeambrun ). I found it highly
annoying that I had to set it in main - but still in airflow they will be
disabled by default.
In CI in branch 2.6 we will set the vars to be "false" by default, so the
tests will be skipped there - even if the change here will be part of 2.6.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
