potiuk commented on code in PR #30255:
URL: https://github.com/apache/airflow/pull/30255#discussion_r1160638071
##########
airflow/dag_processing/manager.py:
##########
@@ -576,8 +585,8 @@ def _run_parsing_loop(self):
while True:
loop_start_time = time.monotonic()
ready = multiprocessing.connection.wait(self.waitables.keys(),
timeout=poll_time)
- if self._job:
- self._job.heartbeat()
+ if hasattr(self._job_runner, "job") and self._job_runner.job is
not None:
Review Comment:
Yep. Having the job defined in generic runner does not fly as it would have
to be added (really) in an __init__ but on the other hand we want to assing the
runer to a job. This might be better addressed later, after the #30376 where
job does not have job_runner reference any more. I will take a close look.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
