hussein-awala commented on code in PR #30524:
URL: https://github.com/apache/airflow/pull/30524#discussion_r1160673964
##########
airflow/providers/smtp/operators/smtp.py:
##########
@@ -80,9 +80,9 @@ def execute(self, context: Context):
with SmtpHook(smtp_conn_id=self.conn_id) as smtp_hook:
return smtp_hook.send_email_smtp(
self.to,
- self.from_email,
self.subject,
self.html_content,
+ self.from_email,
Review Comment:
I prefer to provide the name of each argument to avoid the similar problems
in the future, wdyt?
```diff
@@ -79,10 +79,10 @@ class EmailOperator(BaseOperator):
def execute(self, context: Context):
with SmtpHook(smtp_conn_id=self.conn_id) as smtp_hook:
return smtp_hook.send_email_smtp(
- self.to,
- self.from_email,
- self.subject,
- self.html_content,
+ to=self.to,
+ subject=self.subject,
+ html_content=self.html_content,
+ from_email=self.from_email,
files=self.files,
cc=self.cc,
bcc=self.bcc,
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
