jedcunningham commented on code in PR #30168:
URL: https://github.com/apache/airflow/pull/30168#discussion_r1161059465
##########
tests/charts/test_pgbouncer.py:
##########
@@ -518,6 +518,18 @@ def test_extra_ini_configs(self):
assert "server_round_robin = 1" in ini
assert "stats_period = 30" in ini
+ def test_pgbouncer_deployment_extra_annotations(self):
Review Comment:
Can you add coverage
[here](https://github.com/apache/airflow/blob/0fe73c2e8c0ca90faf54b39139ffab5769f4cca1/tests/charts/test_annotations.py#L371)
instead?
##########
chart/values.yaml:
##########
@@ -1542,6 +1542,8 @@ pgbouncer:
# annotations to be added to the PgBouncer deployment
annotations: {}
+ extraAnnotations: {}
Review Comment:
```suggestion
podAnnotations: {}
```
Let's use podAnnotations instead for consistency across components.
##########
chart/templates/pgbouncer/pgbouncer-deployment.yaml:
##########
@@ -66,6 +66,9 @@ spec:
annotations:
checksum/pgbouncer-config-secret: {{ include (print
$.Template.BasePath "/secrets/pgbouncer-config-secret.yaml") . | sha256sum }}
checksum/pgbouncer-certificates-secret: {{ include (print
$.Template.BasePath "/secrets/pgbouncer-certificates-secret.yaml") . |
sha256sum }}
+{{- if .Values.pgbouncer.extraAnnotations }}
+{{- toYaml .Values.pgbouncer.extraAnnotations | nindent 8 }}
+{{- end }}
Review Comment:
```suggestion
{{- if .Values.pgbouncer.extraAnnotations }}
{{- toYaml .Values.pgbouncer.extraAnnotations | nindent 8 }}
{{- end }}
```
Let's indent it like this instead.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
