potiuk commented on code in PR #30326:
URL: https://github.com/apache/airflow/pull/30326#discussion_r1162330264


##########
airflow/providers/google/provider.yaml:
##########


Review Comment:
   :D I am just intimately familiar with phinxes :) and I know they speak in 
riddles. 
   
   And yes it took me quite a bit of bisecting to find out (this is the 
technique I often use when I am at a loss and remove parts of the commits to 
narrow down the search.
   
   What also helped is https://github.com/apache/airflow/pull/30555 and I think 
we should - at the very least make it possible to have incremental builds for 
the docs (only changed parts) - but I referained from diggung into it as we are 
likely to improve the whole stack of docs building HOPEFULLY soon. Or maybe 
just allow partial generation of only subset of provider. That could have 
helped with bisecting and iterations immensely in such cases.



##########
airflow/providers/google/provider.yaml:
##########


Review Comment:
   :D I am just intimately familiar with Sphinxes :) and I know they speak in 
riddles. 
   
   And yes it took me quite a bit of bisecting to find out (this is the 
technique I often use when I am at a loss and remove parts of the commits to 
narrow down the search.
   
   What also helped is https://github.com/apache/airflow/pull/30555 and I think 
we should - at the very least make it possible to have incremental builds for 
the docs (only changed parts) - but I referained from diggung into it as we are 
likely to improve the whole stack of docs building HOPEFULLY soon. Or maybe 
just allow partial generation of only subset of provider. That could have 
helped with bisecting and iterations immensely in such cases.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to