uranusjr commented on code in PR #30125:
URL: https://github.com/apache/airflow/pull/30125#discussion_r1162408682
##########
airflow/models/taskinstance.py:
##########
@@ -299,11 +299,14 @@ def clear_task_instances(
)
dag_run_state = DagRunState(dag_run_state) # Validate the state value.
for dr in drs:
- dr.state = dag_run_state
- dr.start_date = timezone.utcnow()
- if dag_run_state == DagRunState.QUEUED:
- dr.last_scheduling_decision = None
- dr.start_date = None
+ # Otherwise task(s) cleared in the middle of the running DagRun.
+ # There is no need to reset anything
+ if dr.state in State.finished_dr_states:
Review Comment:
It’d make more sense if the comment says something like _only reset state if
DAG run has finished_ instead (i.e. match the actual condition).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
