potiuk commented on code in PR #30376:
URL: https://github.com/apache/airflow/pull/30376#discussion_r1162829635
##########
airflow/jobs/job.py:
##########
@@ -156,7 +152,10 @@ def kill(self, session: Session = NEW_SESSION) -> NoReturn:
def on_kill(self):
"""Will be called when an external kill command is received."""
- def heartbeat(self, only_if_necessary: bool = False) -> None:
+ @provide_session
+ def heartbeat(
+ self, heartbeat_callback: Callable[[SASession], None], session:
Session = NEW_SESSION
Review Comment:
I copied it from other places where Session has been renamed to SASession,
but it is likely not needed here. I will update it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
