vincbeck commented on code in PR #30460:
URL: https://github.com/apache/airflow/pull/30460#discussion_r1162940298


##########
airflow/providers/amazon/aws/transfers/sql_to_s3.py:
##########
@@ -107,6 +107,7 @@ def __init__(
         verify: bool | str | None = None,
         file_format: Literal["csv", "json", "parquet"] = "csv",
         pd_kwargs: dict | None = None,
+        groupby_kwargs: dict | None = None,

Review Comment:
   Please add it to docstring



##########
tests/system/providers/amazon/aws/example_sql_to_s3.py:
##########
@@ -173,6 +173,18 @@ def delete_security_group(sec_group_id: str, 
sec_group_name: str):
     )
     # [END howto_transfer_sql_to_s3]
 
+    # [START howto_transfer_sql_to_s3_with_groupby_param]
+    sql_to_s3_task_with_groupby = SqlToS3Operator(

Review Comment:
   Please add this one to the `chain` function below. It would add it after 
`sql_to_s3_task `



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to