eladkal commented on code in PR #30598:
URL: https://github.com/apache/airflow/pull/30598#discussion_r1164434190
##########
airflow/providers/google/marketing_platform/operators/campaign_manager.py:
##########
@@ -188,6 +194,11 @@ def __init__(
self.profile_id = profile_id
self.report_id = report_id
self.file_id = file_id
+ if api_version in ["v3.4", "v3.5"]:
+ warnings.warn(
+ f"API {api_version} is deprecated and shortly will be removed.
Please, consider using v4",
+ DeprecationWarning,
+ )
Review Comment:
This is redundant 20 April is just around the corner so these versions won't
be useable any way.
I assume that if one submit `api_version` to the API then the API itself
will reject the request with relevant message? if so no need to add additional
logic from Airflow side..
##########
airflow/providers/google/CHANGELOG.rst:
##########
@@ -233,7 +243,6 @@ Bug Fixes
Misc
~~~~
-
Review Comment:
don't remove this line
##########
airflow/providers/google/CHANGELOG.rst:
##########
@@ -23,6 +23,16 @@
Changelog
---------
+9.1.0
Review Comment:
```suggestion
10.0.0
```
breaking changes in provider requires major release
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
