mikaeld opened a new pull request, #30609: URL: https://github.com/apache/airflow/pull/30609
<!-- Thank you for contributing! Please make sure that your code changes are covered with tests. And in case of new features or big changes remember to adjust the documentation. Feel free to ping committers for the review! In case of an existing issue, reference it using one of the following: closes: #ISSUE related: #ISSUE How to write a good git commit message: http://chris.beams.io/posts/git-commit/ --> Description --- This PR fixes the default probes timeout and period values. Generally, `timeoutSeconds` should be smaller than `periodSeconds`. Here are a [SO question](https://stackoverflow.com/questions/63308717/what-is-the-role-of-timeoutseconds-in-kubernetes-liveness-readiness-probes) addressing this issue and a [blog post](https://cloud.redhat.com/blog/liveness-and-readiness-probes) detailing the Liveness and Readiness Probes. Furthermore, specific k8s implementations such as GKE [do not allow](https://cloud.google.com/load-balancing/docs/health-check-concepts#probes) `timeoutSeconds` > `periodSeconds`. > The timeout is the amount of time that Google Cloud waits for a response to a probe. Its value must be less than or equal to the check interval. Units are seconds. Finally, the webserver probes are the only ones with default values where `timeoutSeconds` > `periodSeconds`. Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more information. In case of fundamental code changes, an Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals)) is needed. In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x). In case of backwards incompatible changes please leave a note in a newsfragment file, named `{pr_number}.significant.rst` or `{issue_number}.significant.rst`, in [newsfragments](https://github.com/apache/airflow/tree/main/newsfragments). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
