mag3141592 commented on code in PR #30166:
URL: https://github.com/apache/airflow/pull/30166#discussion_r1164921696
##########
airflow/providers/common/sql/operators/sql.py:
##########
@@ -585,41 +622,70 @@ def __init__(
partition_clause: str | None = None,
conn_id: str | None = None,
database: str | None = None,
+ accept_none: bool = True,
Review Comment:
`SQLTableCheckOperator` didn't have an `accept_none` param previously, but
`SQLColumnCheckOperator` did and its default is `True`. Ideally these are
consistent, but yes that poses an issue with backward compatibility.
So I'm not sure what the priority is, consistency or backward compatibility?
I would lean toward consistency, but I also made the request 🤷♀️
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
