[
https://issues.apache.org/jira/browse/AIRFLOW-4999?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16889465#comment-16889465
]
ASF GitHub Bot commented on AIRFLOW-4999:
-----------------------------------------
potiuk commented on pull request #5621: [AIRFLOW-4999] Pull and build local
work on both images
URL: https://github.com/apache/airflow/pull/5621
Make sure you have checked _all_ steps below.
### Jira
- [x] My PR addresses the following [Airflow
Jira](https://issues.apache.org/jira/browse/AIRFLOW/) issues and references
them in the PR title. For example, "\[AIRFLOW-XXX\] My Airflow PR"
- https://issues.apache.org/jira/browse/AIRFLOW-4999
NOTE - this build depends on [AIRFLOW-4997] Support for non-master branches
and only last commit is relevant. It should be merged after 4997 is merged.
### Description
- [x] Here are some details about my PR, including screenshots of any UI
changes:
Currently the "local_build" scripts only work on test image, but since we
want to encourage people to run static checks locally, they should also
build/pull&build the slim image.
### Tests
- [x] My PR adds the following unit tests __OR__ does not need testing for
this extremely good reason:
Tested automatically by running all tests.
### Commits
- [x] My commits all reference Jira issues in their subject lines, and I
have squashed multiple commits if they address the same issue. In addition, my
commits follow the guidelines from "[How to write a good git commit
message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
1. Subject is limited to 50 characters (not including Jira issue reference)
1. Subject does not end with a period
1. Subject uses the imperative mood ("add", not "adding")
1. Body wraps at 72 characters
1. Body explains "what" and "why", not "how"
### Documentation
- [x] In case of new functionality, my PR adds documentation that describes
how to use it.
- All the public functions and the classes in the PR contain docstrings
that explain what it does
- If you implement backwards incompatible changes, please leave a note in
the [Updating.md](https://github.com/apache/airflow/blob/master/UPDATING.md) so
we can assign it to a appropriate release
### Code Quality
- [x] Passes `flake8`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> The ci_local_build and ci_local_pull_and_build pull only test image
> --------------------------------------------------------------------
>
> Key: AIRFLOW-4999
> URL: https://issues.apache.org/jira/browse/AIRFLOW-4999
> Project: Apache Airflow
> Issue Type: Improvement
> Components: build, ci
> Affects Versions: 1.10.4, 2.0.0
> Reporter: Jarek Potiuk
> Priority: Major
>
> Currently the "local_build" scripts only work on test image, but since we
> want to encourage people to run static checks locally, they should also
> build/pull&build the slim image.
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
