[
https://issues.apache.org/jira/browse/AIRFLOW-5001?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16889466#comment-16889466
]
ASF GitHub Bot commented on AIRFLOW-5001:
-----------------------------------------
potiuk commented on pull request #5622: [AIRFLOW-5001] Move building images to
before install
URL: https://github.com/apache/airflow/pull/5622
Make sure you have checked _all_ steps below.
### Jira
- [x] My PR addresses the following [Airflow
Jira](https://issues.apache.org/jira/browse/AIRFLOW/) issues and references
them in the PR title. For example, "\[AIRFLOW-XXX\] My Airflow PR"
- https://issues.apache.org/jira/browse/AIRFLOW-5001
NOTE - this build depends on [AIRFLOW-4997] "Support for non-master
branches" and [AIRFLOW-4999] "The ci_local_build and ci_local_pull_and_build
pull only test image" and only last commit is relevant. It should be merged
after 4997 and 4999 are merged.
### Description
- [x] Here are some details about my PR, including screenshots of any UI
changes:
The docker build script is run in the main script which means you have
around 1500 lines of output added to the logs at the beginning. This is useful
but should be hidden by default. This can be solved by moving Docker building
to "before_install" stage which will be automatically folded by Travis CI
(still available but initially hidden in logs).
### Tests
- [x] My PR adds the following unit tests __OR__ does not need testing for
this extremely good reason:
Tested automatically by running all tests.
### Commits
- [x] My commits all reference Jira issues in their subject lines, and I
have squashed multiple commits if they address the same issue. In addition, my
commits follow the guidelines from "[How to write a good git commit
message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
1. Subject is limited to 50 characters (not including Jira issue reference)
1. Subject does not end with a period
1. Subject uses the imperative mood ("add", not "adding")
1. Body wraps at 72 characters
1. Body explains "what" and "why", not "how"
### Documentation
- [x] In case of new functionality, my PR adds documentation that describes
how to use it.
- All the public functions and the classes in the PR contain docstrings
that explain what it does
- If you implement backwards incompatible changes, please leave a note in
the [Updating.md](https://github.com/apache/airflow/blob/master/UPDATING.md) so
we can assign it to a appropriate release
### Code Quality
- [x] Passes `flake8`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> The CI build logs in travis contain image building log in main script
> ---------------------------------------------------------------------
>
> Key: AIRFLOW-5001
> URL: https://issues.apache.org/jira/browse/AIRFLOW-5001
> Project: Apache Airflow
> Issue Type: Improvement
> Components: ci
> Affects Versions: 1.10.4, 2.0.0
> Reporter: Jarek Potiuk
> Priority: Major
>
> The docker build script is run in the main script which means you have around
> 1500 lines of output added to the logs at the beginning. This is useful but
> should be hidden by default. This can be solved by moving Docker building to
> "before_install" stage which will be automatically folded by Travis CI (still
> available but initially hidden in logs).
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
