o-nikolas commented on code in PR #30595:
URL: https://github.com/apache/airflow/pull/30595#discussion_r1165858957
##########
tests/providers/amazon/aws/hooks/test_dynamodb.py:
##########
@@ -55,3 +56,9 @@ def test_insert_batch_items_dynamodb_table(self):
table.meta.client.get_waiter("table_exists").wait(TableName="test_airflow")
assert table.item_count == 10
+
+ @mock.patch("pathlib.Path.exists", return_value=True)
+ def test_waiter_path_generated_from_resource_type(self, _):
+ hook = DynamoDBHook(aws_conn_id="aws_default")
+ path = hook.waiter_path
+ assert path
Review Comment:
Can you assert the path is what you expect rather than just not falsey? That
will ensure your code to get the right `filename` is working as you expect and
won't regress due to future code changes..
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
