m1racoli commented on a change in pull request #5619: [AIRFLOW-4998] Run
multiple queries in BigQueryOperator
URL: https://github.com/apache/airflow/pull/5619#discussion_r305580323
##########
File path: airflow/contrib/operators/bigquery_operator.py
##########
@@ -192,24 +192,46 @@ def execute(self, context):
)
conn = hook.get_conn()
self.bq_cursor = conn.cursor()
- job_id = self.bq_cursor.run_query(
- sql=self.sql,
- destination_dataset_table=self.destination_dataset_table,
- write_disposition=self.write_disposition,
- allow_large_results=self.allow_large_results,
- flatten_results=self.flatten_results,
- udf_config=self.udf_config,
- maximum_billing_tier=self.maximum_billing_tier,
- maximum_bytes_billed=self.maximum_bytes_billed,
- create_disposition=self.create_disposition,
- query_params=self.query_params,
- labels=self.labels,
- schema_update_options=self.schema_update_options,
- priority=self.priority,
- time_partitioning=self.time_partitioning,
- api_resource_configs=self.api_resource_configs,
- cluster_fields=self.cluster_fields,
- )
+ if isinstance(self.sql, str):
+ job_id = self.bq_cursor.run_query(
+ sql=self.sql,
+ destination_dataset_table=self.destination_dataset_table,
+ write_disposition=self.write_disposition,
+ allow_large_results=self.allow_large_results,
+ flatten_results=self.flatten_results,
+ udf_config=self.udf_config,
+ maximum_billing_tier=self.maximum_billing_tier,
+ maximum_bytes_billed=self.maximum_bytes_billed,
+ create_disposition=self.create_disposition,
+ query_params=self.query_params,
+ labels=self.labels,
+ schema_update_options=self.schema_update_options,
+ priority=self.priority,
+ time_partitioning=self.time_partitioning,
+ api_resource_configs=self.api_resource_configs,
+ cluster_fields=self.cluster_fields,
+ )
+ else:
Review comment:
Good point. I was thinking about that non-iterable case. The question is, do
we allow dicts, which are iterables as well?
Regarding annotations, could we have mixed type annotations, like
```def fun(sql: str or iterable):```
or should we just annotate with `iterable`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
