potiuk commented on PR #30175: URL: https://github.com/apache/airflow/pull/30175#issuecomment-1509721143
Thanks @dylanbstorey for being so receptive to out expectations! I love the way it is now nicely integrated into our testing framework, it's going to be really easy to maintain it in the future. I think for any new provider we are going to accept, we will point to this PR with "And here is how you do it" :). @eladkal - waiting for your re-review. @ephraimbuddy @jedcunningham @eladkal @kaxil - if we merge it before Monday. then I think we will have a chance to include it in 2.6 constraints and extras (we will need to cherry-pick at least part of it to 2.6.0 branch - easiest it will be to cherry-pick the whole of it - to include Kafka in extras of Airlfow and constraints for 2.6.0. I also think, taking into account Kafka's popularity, it **might** be a good idea to make it installed as part of the PROD image of ours (it will slightly increase the size of our image with confluent and asgiref added as dependency) WDYT? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
